Skip to content

Allow raw `tls_options` to be passed in LDAP configuration

Drew Blessing requested to merge dblessing/gitlab-ce:add_ldap_tls_options into master

What does this MR do?

It's the GitLab counterpart to omniauth-ldap!12 (merged). It exposes the full tls_options hash so users can set any LDAP TLS options, like ssl_version, ca_file or ciphers. Basically, anything OpenSSL supports...

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

We're seeing more and more customers in highly secure environments and they need the ability to set specific ciphers that are allowed. In many cases, without the ability to restrict ciphers, LDAP was simply not allowing connections.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/46391

Edited by Drew Blessing

Merge request reports