Feature: Runner type filter for admin view
What does this MR do?
- Adds a filter by runner type (instance_type, group_type, project_type) to the admin runners view.
- Adds two new parameters to the runners API:
type
andstatus
- Deprecates the
scopes
parameters which contains too many different filters and legacy values for the obsoleteshared
andspecific
scopes (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9646). Also, combining multiple filters with only onescopes
parameter was not possible.
This MR depends on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19625.
Are there points in the code the reviewer needs to double check?
I introduced a deprecation on the API. This may or may not be ok.
Why was this MR needed?
The admin runners view currenlty makes it hard to search for runners if there are a lot of runners.
One use case that this MR solves is that there should be way to find runners by a certain type. This allows for easier troubleshooting.
The development of this MR is sponsored by @ siemens (/cc @bufferoverflow).
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conform by the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
Conform by the merge request performance guides -
Conform by the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/38504 and https://gitlab.com/gitlab-org/gitlab-ce/issues/36781.
Edited by Kamil Trzciński