Resolve "Rename the `Master` role to `Maintainer`"
EE port at https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5948
Follow up (changes for backend): https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19413
What does this MR do?
Rename permission name "Master" to "Maintainer", from user's perspective.
No need to worry about API because it does not use permission level names, but level number.
-
EE check for ProjectCreationLevel|MastersandDevelopers + Mastersand so on...
Are there points in the code the reviewer needs to double check?
Internal method call/constant changes are in the followup MR, because:
- reduce probability of conflict
- separate the safe changes from risky changes, so we can rollback risky changes in case something goes wrong, but keep safe changes.
Why was this MR needed?
See #42751 (closed)
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests changed for this feature/bug - Conform by the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
Conform by the merge request performance guides -
Conform by the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
End-to-end tests pass ( package-and-qamanual pipeline job)
What are the relevant issue numbers?
Closes #42751 (closed)
Merge request reports
Activity
added 3 commits
added 3 commits
added 4 commits
Toggle commit listmarked the checklist item Documentation created/updated as completed
marked the checklist item Changelog entry added, if necessary as completed
Hi @oswaldo nice to meet you. Could you help me review this please? Thanks.
I think it is better to review the EE MR since it contains more changes.
assigned to @oswaldo
assigned to @lulalala
added 94 commits
-
abf1a4a9...23ae072b - 81 commits from branch
master - 7c6770c5 - Rename master to maintainer
- 87e329cd - Rename “Developers + Masters”
- d23616e8 - Fix spec
- a1fa2ec9 - Doc update
- 22d4559f - View update
- b77964f2 - wording
- de2eb1c6 - doc
- 30f31118 - change wording
- fb23139b - group runners
- 2487d74d - lock permission
- a1fd8ab8 - policy
- a270e051 - doc
- b4470d87 - fix lock spec
Toggle commit list-
abf1a4a9...23ae072b - 81 commits from branch
mentioned in merge request !19413 (merged)
assigned to @oswaldo
assigned to @lulalala
-
Hi @smcgivern do you have time to review this? Thanks.
assigned to @smcgivern
added 313 commits
-
691870ec...ddabde54 - 297 commits from branch
master - a8b570d8 - Rename master to maintainer
- cfcc7043 - Rename “Developers + Masters”
- 7c965a24 - Fix spec
- d5a303cf - Doc update
- dc28ef01 - View update
- 8c24e78b - wording
- 15469fe0 - doc
- a6c15c5b - change wording
- 748f8fef - group runners
- 5ee56c9a - lock permission
- a0b67844 - policy
- 1c7ab76b - doc
- 9fa70462 - fix lock spec
- faf00731 - add changelog
- 9980869d - Update readme
- dd42cab9 - Update gitlab flow doc
Toggle commit list-
691870ec...ddabde54 - 297 commits from branch
mentioned in commit e9ad837c
mentioned in issue gitlab-org/release/tasks#247 (closed)
added feature freeze label
mentioned in issue #47005 (closed)
mentioned in issue #48402 (closed)
added devopsplan label