Resolve "NoMethodError: undefined method `present' for #<GenericCommitStatus:0x00007f6eacf34a40>" (!18979) · Merge requests · GitLab.org / GitLab FOSS · GitLab

The 17.0 major release is coming on May 16, 2024! This version brings many exciting improvements to GitLab, but also removes some deprecated features. We are introducing three breaking change windows during which we expect breaking changes to be deployed to GitLab.com. You can read more about it on our blogpost . The first breaking change window begins 2024-04-22 09:00UTC and ends 2024-04-24 22:00UTC.

Mayra Cabrera requested to merge 46177-fix-present-on-generic-commit-status into master May 15, 2018

What does this MR do?

Makes CommitStatus and GenericCommitStatus respond to presentable methods, by including Presentable module into CommitStatus

Why was this MR needed?

JobSerializer methods were failing for GenericCommitStatus instances. Including Presentable module into CommitStatus fixes the problem

Does this MR meet the acceptance criteria?

Changelog entry added, if necessary
Tests added for this feature/bug
Conform by the code review guidelines
- Has been reviewed by a Backend maintainer
Conform by the merge request performance guides
Conform by the style guides
If you have multiple commits, please combine them into a few logically organized commits by squashing them
Internationalization required/considered
End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Closes #46177 (closed)

Edited May 17, 2018 by Grzegorz Bizon