Skip to content
Snippets Groups Projects

Remove all tables from Pipeline page when there is no job for the Pipeline

Merged Takuya Noguchi requested to merge tnir/gitlab-foss:45669-table-in-jobs-on-pipeline into master

What does this MR do?

Remove all the tables (Pipelines/Jobs) from Pipeline when there is no job to show for the Pipeline.

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

To improve UX a little bit by removing a meaningless.

Screenshots (if relevant)

case (after the MR) screenshots
Pipeline for a commit with invalid CI YAML (improved by the MR) gitlab-ce-mr-18540-invalid-gitlab-ci-yaml
Pipeline for a commit with valid CI YAML (no regression by the MR) gitlab-ce-mr-18540-invalid-gitlab-ci-yaml-no-regressions

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #45669 (closed)

Edited by Takuya Noguchi

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @tnir I think we could tweak the conditions a bit and we don't need to update the test. I also think this page could use more improvement, but surely not in this merge request :) Thanks for improvement!

  • Lin Jen-Shin changed milestone to %10.8

    changed milestone to %10.8

  • assigned to @tnir

  • mentioned in issue #45669 (closed)

  • @tnir I am going to defer this discussion to the issue, as this involves UX and no solution was yet discussed before implementation began :wink:

    please see https://gitlab.com/gitlab-org/gitlab-ce/issues/45669#note_70892919

  • Takuya Noguchi added 1 commit

    added 1 commit

    • e9e3d790 - Hide Job table on Pipeline when no Jobs

    Compare with previous version

  • Takuya Noguchi changed milestone to %11.0

    changed milestone to %11.0

  • Author Developer

    I have to move this to %11.0.

  • Takuya Noguchi added 2131 commits

    added 2131 commits

    Compare with previous version

  • Takuya Noguchi added 529 commits

    added 529 commits

    Compare with previous version

  • Takuya Noguchi changed milestone to %11.1

    changed milestone to %11.1

  • Author Developer

    I have to move this to %11.1.

  • Removing milestone for now @tnir

    Let's await final empty state design in the issue at https://gitlab.com/gitlab-org/gitlab-ce/issues/45669#note_90293955

  • Dimitrie Hoekstra removed milestone

    removed milestone

  • Hi @tnir,

    First of all, thank you for creating a Merge Request to help improve the GitLab product. We are running through old Merge Requests and asking authors to update their Merge Requests

    This Merge Request was chosen, as it meets the following criteria:

    We'd like to ask you to help us out and let us know whether:

    • You would like to continue the work here
    • You would like us to take on the Merge Request for you
    • You would like us to close down the Merge Request

    Thanks for your help

    Improve this comment

  • Takuya Noguchi added 7406 commits

    added 7406 commits

    Compare with previous version

  • Author Developer

    I'm sorry for being delayed for updating the MR.

    @godfat Could you review this again before suggest this idea to UX team?

  • Takuya Noguchi changed title from Remove Jobs table from Pipeline when there is no job to Remove all table from Pipeline page when there is no job for the Pipeline

    changed title from Remove Jobs table from Pipeline when there is no job to Remove all table from Pipeline page when there is no job for the Pipeline

  • Takuya Noguchi changed title from Remove all table from Pipeline page when there is no job for the Pipeline to Remove all tables from Pipeline page when there is no job for the Pipeline

    changed title from Remove all table from Pipeline page when there is no job for the Pipeline to Remove all tables from Pipeline page when there is no job for the Pipeline

  • Takuya Noguchi changed the description

    changed the description

  • Takuya Noguchi added 1 commit

    added 1 commit

    • dce11702 - Hide all tables on Pipeline when no Jobs for the Pipeline

    Compare with previous version

  • Takuya Noguchi resolved all discussions

    resolved all discussions

  • assigned to @godfat

  • Takuya Noguchi added 1 commit

    added 1 commit

    • cb53f856 - Hide all tables on Pipeline when no Jobs for the Pipeline

    Compare with previous version

  • Lin Jen-Shin
  • @tnir No problems. Sorry that UX didn't seem to have progress here. The code and UX looks good to me (though I didn't really try it), but I think we'll need to tweak the tests.

  • assigned to @tnir

  • @dimitrieh Could you please also check the UX here? I think the screenshot should be up-to-date.

  • @godfat left a few comments, but looking good!

  • mentioned in issue #52086 (closed)

  • Takuya Noguchi added 1 commit

    added 1 commit

    • 8993e211 - Hide all tables on Pipeline when no Jobs for the Pipeline

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading