Remove all tables from Pipeline page when there is no job for the Pipeline
What does this MR do?
Remove all the tables (Pipelines/Jobs) from Pipeline when there is no job to show for the Pipeline.
Are there points in the code the reviewer needs to double check?
No.
Why was this MR needed?
To improve UX a little bit by removing a meaningless.
Screenshots (if relevant)
case (after the MR) | screenshots |
---|---|
Pipeline for a commit with invalid CI YAML (improved by the MR) | ![]() |
Pipeline for a commit with valid CI YAML (no regression by the MR) | ![]() |
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - [n/a] Documentation created/updated
- [n/a] API support added
- [n/a] Tests added for this feature/bug
- Review
-
Has been reviewed by UX -
Has been reviewed by Frontend - [n/a] Has been reviewed by Backend
- [n/a] Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together - [n/a] Internationalization required/considered
- [n/a] End-to-end tests pass (
package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #45669 (closed)
Merge request reports
Activity
added ~2278654 Community contribution UX typebug labels
marked the checklist item Changelog entry added, if necessary as completed
marked the checklist item Conform by the merge request performance guides as completed
marked the checklist item Conform by the style guides as completed
marked the checklist item Squashed related commits together as completed
added 30 commits
-
bf0999af...54b97f9c - 29 commits from branch
gitlab-org:master
- ea35e4fa - Hide Job table on Pipeline when no Jobs
-
bf0999af...54b97f9c - 29 commits from branch
Note: relevant test cases have Jobs without
.gitlab-ci.yml
committed due to creating a pipeline without commit.assigned to @godfat
@godfat Could you review this?
@tnir Thanks. Honestly I stared at it for awhile, and can't figure out the difference. Here's the screenshot:
After I switched back to master, I realized that there's an empty table below that error. Apparently I didn't pay attention there.
@dimitrieh If I clicked on the pipeline tab, there's nothing. I need to click on the
Jobs (0)
tab in order to see the error. Is there a plan to improve this?- Resolved by Takuya Noguchi
@tnir I think we could tweak the conditions a bit and we don't need to update the test. I also think this page could use more improvement, but surely not in this merge request :) Thanks for improvement!
changed milestone to %10.8
assigned to @tnir
mentioned in issue #45669 (closed)
@tnir I am going to defer this discussion to the issue, as this involves UX and no solution was yet discussed before implementation began
please see https://gitlab.com/gitlab-org/gitlab-ce/issues/45669#note_70892919
changed milestone to %11.0
I have to move this to %11.0.
added 2131 commits
-
e9e3d790...65bfec65 - 2130 commits from branch
gitlab-org:master
- c0dfa6f6 - Hide Job table on Pipeline when no Jobs
-
e9e3d790...65bfec65 - 2130 commits from branch
added 529 commits
-
c0dfa6f6...fe0ebf76 - 528 commits from branch
gitlab-org:master
- 2dd14f53 - Hide Job table on Pipeline when no Jobs
-
c0dfa6f6...fe0ebf76 - 528 commits from branch
changed milestone to %11.1
I have to move this to %11.1.
Removing milestone for now @tnir
Let's await final empty state design in the issue at https://gitlab.com/gitlab-org/gitlab-ce/issues/45669#note_90293955
Hi @tnir,
First of all, thank you for creating a Merge Request to help improve the GitLab product. We are running through old Merge Requests and asking authors to update their Merge Requests
This Merge Request was chosen, as it meets the following criteria:
- Open
- Labelled Community contribution
- No activity in the past 2 months (since 2018-07-25T13:27:54.627Z)
We'd like to ask you to help us out and let us know whether:
- You would like to continue the work here
- You would like us to take on the Merge Request for you
- You would like us to close down the Merge Request
Thanks for your help
Improve this comment
added auto updated awaiting feedback labels
added 7406 commits
-
2dd14f53...a310a638 - 7405 commits from branch
gitlab-org:master
- 3f3d6ef1 - Hide Job table on Pipeline when no Jobs
-
2dd14f53...a310a638 - 7405 commits from branch
removed auto updated awaiting feedback labels
I'm sorry for being delayed for updating the MR.
@godfat Could you review this again before suggest this idea to UX team?
added 1 commit
- dce11702 - Hide all tables on Pipeline when no Jobs for the Pipeline
assigned to @godfat
added 1 commit
- cb53f856 - Hide all tables on Pipeline when no Jobs for the Pipeline
- Resolved by Takuya Noguchi
@tnir No problems. Sorry that UX didn't seem to have progress here. The code and UX looks good to me (though I didn't really try it), but I think we'll need to tweak the tests.
assigned to @tnir
@dimitrieh Could you please also check the UX here? I think the screenshot should be up-to-date.
- Resolved by Takuya Noguchi
@godfat left a few comments, but looking good!
mentioned in issue #52086 (closed)
added 1 commit
- 8993e211 - Hide all tables on Pipeline when no Jobs for the Pipeline