Skip to content

Resolve "Disabling Pipelines for a project does not disable "Only allow merge requests to be merged if the pipeline succeeds""

What does this MR do?

FE: Always show the "only merge when pipeline succeeds" checkbox in a project's merge request settings, even if the pipelines feature for the project is disabled.

BE: Ignore the "only merge when pipeline succeeds" setting if the project's pipelines feature is disabled. But do not change it.

EE compat: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5996

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Screen_Shot_2018-04-18_at_17.09.24

Screen_Shot_2018-05-22_at_15.45.41

Screen_Shot_2018-05-22_at_15.46.06

Screen_Shot_2018-05-22_at_15.46.12

Screen_Shot_2018-05-22_at_15.46.15

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #39206 (moved)

Edited by Luke Bennett

Merge request reports