Skip to content

WIP: Group Runner Can Be Added From Group > Settings > CI/CD

TODO

  • Allow show,edit,pause,resume,destroy of group runner
  • Keep runner setup instructions around after adding runner

What does this MR do?

Moves the group runner setup to group settings and adds link to this from project settings

Are there points in the code the reviewer needs to double check?

  • Will we have conflicts with new routes for group runners (eg. subgroups might cause an issue?)
    • edit_group_runner_path
    • group_runner_path
    • resume_group_runner_path
    • pause_group_runner_path
  • Is can?(current_user, :admin_pipeline, group) appropriate for pause,resume,edit runner?
  • Do we need specs for Groups::RunnersController where we test the security?

Why was this MR needed?

Screenshots (if relevant)

group CI/CD settings before adding runner

group_CI_CD_settings_before_adding_runner

group CI/CD settings after adding runner

group_CI_CD_settings_after_adding_runner

project CI/CD settings before adding group runner

project_CI_CD_settings_before_adding_group_runner

project CI/CD settings after adding group runner

project_CI_CD_settings_after_adding_group_runner

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#10244 (closed)

Edited by Kamil Trzciński

Merge request reports