Minimal fix for artifacts service
What does this MR do?
This is a minimal fix for solving artifacts trace to be gone during trace creation.
It makes a use of temporary file which holds data, and only after data is created in final structure we remove old files, so technically it is still accessible.
Well, it seems that this is very important fix as it can result in data loss as in case when DB is gone we gonna
move file trace file to the tmp/cache, if it fails the file is not gonna be moved back to previous location.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Tests added for this feature/bug - Review
-
Has been reviewed by Backend
-
What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/43022
Related https://gitlab.com/gitlab-com/infrastructure/issues/3756
Edited by Grzegorz Bizon