Fix 500 error when loading an invalid upload URL

What does this MR do?

Fix a 500 error when accessing a legacy URL like https://gitlab.com/uploads/project/avatar/13083/gitlab-logo-square.png

The previous behaviour was confusing, but I've gone with the same thing: if you're logged in, you get a 404. If you're logged out, you are asked to sign in.

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/4998.

added 1 commit

• 61ab9263 - Fix 500 error when loading an invalid upload URL

Compare with previous version

Do you want to implement the 301 for the the cases where only the -/system part is missing?

added 1 commit

• 028562a0 - Fix 500 error when loading an invalid upload URL

Compare with previous version

Do you want to implement the 301 for the the cases where only the -/system part is missing?

I don't think so, at least not in a patch to 10.5. We never supported these old URLs anyway, and to do this we'd have to look up the uploaders twice (or we'd potentially redirect you to another 404), so I'd like to treat that as a separate issue if we do want it.

resolved all discussions

Thanks @mbergeron, I added a comment! EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4673

approved this merge request

Seems good , merge when green.

assigned to @smcgivern

mentioned in commit 05f4788e

merged

Picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17322, will merge into 10-5-stable ready for 10.5.2

mentioned in commit fd6018b9

mentioned in issue gitlab-org/release/tasks#106 (closed)

mentioned in issue gitlab-org/release/tasks#116 (closed)

added devopsplan label