Skip to content

add a cc quick action for issuable

Callum Styan requested to merge cstyan/gitlab-ce:callum-24615 into master

@smcgivern

What does this MR do?

Add's a CC quick action that creates a system note and todo for each CC'ed user.

Are there points in the code the reviewer needs to double check?

I had to comment out the inclusion of BlocksJsonSerialization in the user model, otherwise I always got a serialization disabled message when trying to post a /cc @user comment. Maybe there's a necessary change that I missed?

Also, I could not get the tests to run properly locally via the docs that I was able to find about them.

We'd discussed adding a cc service, but when I sat down to work on this it felt like having CC in the base issuable and common system notes classes made more sense. Let me know if this is okay.

Why was this MR needed?

to add the cc quick action

Screenshots (if relevant)

2018-02-07-225110_961x132_scrot 2018-02-07-225148_1299x369_scrot

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

24615

Edited by Callum Styan

Merge request reports