Try not to hold env and release the controller after the request.
What does this MR do?
Try not to hold env and release the controller after the request.
Why was this MR needed?
This way, we could release the project referred from the controller, which potentially referred a repository which potentially allocated a lot of memories.
Before this change, we could hold the last request data and cannot release the memory. After this change, the largest request data should be able to be collected from GC.
This might not impact the instances having heavy load, as the last request should be changing all the time, and GC won't kick in for each request anyway.
However it could still potentially allow us to free more memories for each GC runs, because now we could free one more request anyway.
Does this MR meet the acceptance criteria?
-
Documentation created/updated -
Tests added for this feature/bug - Review
-
Has been reviewed by Backend
-
What are the relevant issue numbers?
This could be used together with https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16797