Skip to content

WIP: Maintain modal state internally

Inactive Account requested to merge winh-modal-internal-state into master

What does this MR do?

Move isVisible into the shared modal Vue component and provide show(), hide(), cancel(), and submit() methods.

Why was this MR needed?

Otherwise every place that uses the modal component needs to maintain their own isVisible which is a lot of duplicate code.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Frontend

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/28849

fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/41584

Edited by Inactive Account

Merge request reports