Skip to content

Resolve "Issue note icons wrong color"

Simon Knox requested to merge 40459-svg-icon-fix into master

What does this MR do?

  • remove overly specific btn styles for svgs (affected Note icons)
  • remove .projects-list a style (affected project list CI icons
  • add hover styles to ci-icons to override a:hover styles from bootstrap's scaffolding.scss

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3565

Are there points in the code the reviewer needs to double check?

Also moved the .text-* styles to where the other color utils are. There may be a better place to put them

Screenshots (if relevant)

Screen_Shot_2017-11-23_at_4.28.24_pm_copy

Screen_Shot_2017-11-23_at_4.28.10_pm_copy

NB links in Project descriptions are now blue. I think this is better than current (they are plain text), but this prob needs a UX-ok

Screen_Shot_2017-11-28_at_8.07.24_am_copy

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #40459 (closed)

Edited by Simon Knox

Merge request reports