Skip to content
Snippets Groups Projects

Use Redis cache for branch existence checks

Merged Jacob Vosmaer requested to merge branch-exists-redis into master

What does this MR do?

Change Repository#branch_exists? so that it uses Repository#branch_names, which is cached in Redis.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Memoizing in the Repository instance lead to a performance degradation. https://gitlab.com/gitlab-org/gitlab-ce/issues/40349.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/40349

Edited by Jacob Vosmaer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading