Pass git object dir attributes as relative paths to Gitaly

What does this MR do?

Reference gitaly#629 (closed)

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests added for this feature/bug
• Review
  • Has been reviewed by UX
  • Has been reviewed by Frontend
  • Has been reviewed by Backend
  • Has been reviewed by Database
• Conform by the merge request performance guides
• Conform by the style guides
• Squashed related commits together

What are the relevant issue numbers?

restored source branch fix/pass-git-object-dir-attrs-as-relative

mentioned in issue gitaly#629 (closed)

changed the description

assigned to @jacobvosmaer-gitlab

added 1 commit

• 32c2bfea - Pass git object dir attributes as relative paths to Gitaly

Compare with previous version

@ahmadsherif I think this should also touch lib/gitlab/git/repository.rb. https://gitlab.com/gitlab-org/gitlab-ce/blob/cbc7d62c2982135d5edd8e1ea1c32d35cc60d46f/lib/gitlab/git/repository.rb#L1223

Think of what happens when a push is received by a Gitaly server. The absolute paths set in the variables won't work with Rugged/NFS. But, every time we instantiate a Rugged instance for use with Rugged/NFS, we now put the variables into Rugged unchanged.

We need something like this in lib/gitlab/git/repository.rb:

def alternate_object_directories
  incorrect_absolute_dirs = Gitlab::Git::Env.all.values_at(*ALLOWED_OBJECT_DIRECTORIES_VARIABLES).compact
  # Combine relative path from Env with the current Repository#path 
  incorrect_absolute_dirs.map { |d| File.join(path, Env.relative_path(d) }
end

assigned to @ahmadsherif

changed milestone to %10.2

added 396 commits

• 32c2bfea...1c0407e8 - 395 commits from branch master
• a6af21a4 - Pass git object dir attributes as relative paths to Gitaly

Compare with previous version

added 1 commit

• ed3d2edf - Pass git object dir attributes as relative paths to Gitaly

Compare with previous version

added 31 commits

• ed3d2edf...d6170ce4 - 30 commits from branch master
• 612e6e09 - Pass git object dir attributes as relative paths to Gitaly

Compare with previous version

assigned to @jacobvosmaer-gitlab

@ahmadsherif this should be %10.1 with ~"Pick into Stable", rather than %10.2, no?

assigned to @ahmadsherif

added 1 commit

• 96732d3b - Pass git object dir attributes as relative paths to Gitaly

Compare with previous version

assigned to @jacobvosmaer-gitlab

assigned to @ahmadsherif

changed milestone to %10.1

mentioned in issue gitaly#348 (closed)

mentioned in issue gitaly#516 (closed)

added 87 commits

• 96732d3b...143ace07 - 86 commits from branch master
• c3397830 - Pass git object dir attributes as relative paths to Gitaly

Compare with previous version

assigned to @DouweM

assigned to @ahmadsherif

added 1 commit

• 4378f56c - Pass git object dir attributes as relative paths to Gitaly

Compare with previous version

assigned to @DouweM

resolved all discussions

approved this merge request

merged

mentioned in commit a6d09bc6

changed milestone to %10.2

added devopscreate groupgitaly labels