Skip to content

Add view replaced file link for image diffs

Clement Ho requested to merge add-view-replaced-file-link into master

What does this MR do?

Instead of having each image in the replaced image diff link to it's file commit, we are moving that link to the header toolbar as proposed in https://gitlab.com/gitlab-org/gitlab-ce/issues/35873#edge-case in order to prep for commenting on image diffs.

Are there points in the code the reviewer needs to double check?

Shouldn't be

Why was this MR needed?

Prep for Deliverable

Screenshots (if relevant)

Before After
Screen_Shot_2017-09-20_at_9.44.58_AM Screen_Shot_2017-09-20_at_9.43.45_AM

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/35873

Edited by Rémy Coutable

Merge request reports