Skip to content
Snippets Groups Projects

Ensure Rugged methods are called with a Rugged Commit

Merged Alejandro Rodríguez requested to merge gitaly-9-5-patch into 9-5-stable-patch-1

What does this MR do?

Ensure Rugged methods are called with a Rugged::Commit. In 9.6, these changes were already brought by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13094, so they're only needed in 9.5.

Are there points in the code the reviewer needs to double check?

No

Why was this MR needed?

Some Gitaly features will make Gitaly::Commit the raw commit object, which will result in errors for methods that are expecting a Rugged::Commit as the raw object.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/36718

Edited by Alejandro Rodríguez

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading