Skip to content
Snippets Groups Projects

Fix "Cannot connect to CI server error messages"

What does this MR do?

This MR fixes "Cannot connect to CI server error messages" by @ayufan's assumption.

The problem is with the ordering of operations.

We do:

  • INSERT ci_pipelines, UPDATE merge_request WITH ci_pipeline,

  • SELECT ci_pipelines, INSERT merge_request.

Where we should do:

  • INSERT ci_pipelines, UPDATE merge_request WITH ci_pipeline,

  • INSERT merge_request, UPDATE merge_request WITH ci_pipeline,

Are there points in the code the reviewer needs to double check?

Does this truly fix the problem?

Why was this MR needed?

This is regression . This priority is quite high.

Screenshots (if relevant)

N/A

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

/cc @ayufan @stanhu @rspeicher

Edited by Shinya Maeda

Merge request reports

Pipeline #10584928 passed

Pipeline passed for 1614eb8b on fix/sm/34547-cannot-connect-to-ci-server-error-messages

Test coverage 70.82% (20.80%) from 2 jobs
Approval is optional

Merged by avatar (Mar 12, 2025 5:06pm UTC)

Merge details

Pipeline #10603623 failed

Pipeline failed for edc81ea6 on master

Test coverage 50.04% (20.80%) from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading