Skip to content
Snippets Groups Projects

Perform project housekeeping after importing projects

Merged Douglas Barbosa Alexandre requested to merge fix-34019 into master
All threads resolved!
Edited by Douglas Barbosa Alexandre

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Douglas Barbosa Alexandre unmarked as a Work In Progress

    unmarked as a Work In Progress

  • @jameslopez Can you review, please?

  • Thanks @dbalexandre! I wonder if we should really do this in project.rb:

     after_transition started: :finished

    That way all imports will run it, as I think we'll need this for all imports...

  • @dbalexandre if this needs to be in a 9.3 patch, it should have ~"Pick into Stable", otherwise it should be 9.4. Thanks for doing this so quickly!

  • Douglas Barbosa Alexandre resolved all discussions

    resolved all discussions

  • added 48 commits

    Compare with previous version

  • Douglas Barbosa Alexandre changed title from Perform project housekeeping after importing projects from GitHub to Perform project housekeeping after importing projects

    changed title from Perform project housekeeping after importing projects from GitHub to Perform project housekeeping after importing projects

  • @jameslopez Thanks! Could you have another look?

  • thanks @dbalexandre, good stuff! Left a couple of comments/questions...

  • Douglas Barbosa Alexandre resolved all discussions

    resolved all discussions

  • added 2 commits

    • c968afc7 - Break Project#perform_housekeeping in two methods
    • f1c5aaa7 - Check if repository exists before performing housekeeping

    Compare with previous version

  • @smcgivern Can you review, please?

  • added 212 commits

    • f1c5aaa7...a4c81b64 - 208 commits from branch master
    • 6694e2cd - Perform project housekeeping after importing projects
    • 087c1056 - Add CHANGELOG
    • e9732404 - Break Project#perform_housekeeping in two methods
    • 429c3ccc - Check if repository exists before performing housekeeping

    Compare with previous version

  • LGTM, thanks! :100:

  • Sean McGivern approved this merge request

    approved this merge request

  • merged

  • Sean McGivern mentioned in commit 1393f8dd

    mentioned in commit 1393f8dd

  • Picked into 9-3-stable, will go in 9.3.1.

  • Sean McGivern mentioned in commit 1180a335

    mentioned in commit 1180a335

  • mentioned in issue #34417 (closed)

  • Please register or sign in to reply
    Loading