Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Make issuable sidebar setSidebarHeight more efficient
All threads resolved!
All threads resolved!
- Moves logic for
setSidebarHeight
intosidebar_height_manager
to allow for better code sharing with bulk update sidebar. - Makes
setSidebarHeight
more efficient, by preventing its being called when sidebar state hasn't changed.
Edited by Bryce Johnson
Merge request reports
Activity
added 1 commit
- 518f4941 - Move setSidebarHeight into SidebarHeightManager.
added 1 commit
- 059fea55 - Implement SidebarHeightManager in bulk update sidebar.
added 6 commits
-
059fea55...f01c5d86 - 5 commits from branch
master
- 74e00e25 - Make setSidebarHeight more efficient.
-
059fea55...f01c5d86 - 5 commits from branch
mentioned in issue #33984 (closed)
- Resolved by Bryce Johnson
added 714 commits
-
74e00e25...9ef6d028 - 713 commits from branch
master
- d6d51316 - Make setSidebarHeight more efficient.
-
74e00e25...9ef6d028 - 713 commits from branch
@timzallmann I see we were both working on this recently. Would you like to review?
assigned to @timzallmann
added 1 commit
- 4552c5c0 - Use arrow functions to set context, don't use window.find.
mentioned in issue #34476 (closed)
- Resolved by Tim Zallmann
assigned to @brycepj
added 170 commits
-
9e878bfc...1a449b24 - 169 commits from branch
master
- 728be6af - Make setSidebarHeight more efficient with SidebarHeightManager.
-
9e878bfc...1a449b24 - 169 commits from branch
assigned to @timzallmann
changed milestone to %9.4
mentioned in commit b071317c
Please register or sign in to reply