Skip to content
Snippets Groups Projects

Make issuable sidebar setSidebarHeight more efficient

Merged Bryce Johnson requested to merge set-sidebar-height into master
All threads resolved!
  1. Moves logic for setSidebarHeight into sidebar_height_manager to allow for better code sharing with bulk update sidebar.
  2. Makes setSidebarHeight more efficient, by preventing its being called when sidebar state hasn't changed.
Edited by Bryce Johnson

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bryce Johnson resolved all discussions

    resolved all discussions

  • Bryce Johnson changed the description

    changed the description

  • Bryce Johnson added 714 commits

    added 714 commits

    Compare with previous version

  • Bryce Johnson changed the description

    changed the description

  • Author Contributor

    @timzallmann I see we were both working on this recently. Would you like to review?

  • Bryce Johnson changed the description

    changed the description

  • Bryce Johnson added 1 commit

    added 1 commit

    • 4552c5c0 - Use arrow functions to set context, don't use window.find.

    Compare with previous version

  • Bryce Johnson added 1 commit

    added 1 commit

    • 2db06aca - Remove accidentally commited swo.

    Compare with previous version

  • mentioned in issue #34476 (closed)

  • Bryce Johnson added 1 commit

    added 1 commit

    Compare with previous version

  • Bryce Johnson added 1 commit

    added 1 commit

    Compare with previous version

  • Tim Zallmann
  • assigned to @brycepj

  • Bryce Johnson added 170 commits

    added 170 commits

    Compare with previous version

  • Bryce Johnson changed milestone to %9.4

    changed milestone to %9.4

  • Tim Zallmann resolved all discussions

    resolved all discussions

  • Tim Zallmann approved this merge request

    approved this merge request

  • merged

  • Tim Zallmann mentioned in commit b071317c

    mentioned in commit b071317c

  • Please register or sign in to reply
    Loading