Rebuild the dynamic path before validating it (!12213) · Merge requests · GitLab.org / GitLab FOSS

Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.

Merged Bob Van Landuyt requested to merge bvl-validate-path-update into master 7 years ago

What does this MR do?

Instead of validating the old Routable#full_path when updating the path attribute, the DynamicPathValidator will now rebuild the full path to be validated. That way the path has the updated attribute before checking.

Why was this MR needed?

Without this, it would be possible to update a path to something reserved. Since the validation would happen on the old full path that was loaded & cached.

Closes #33746 (closed)

@DouweM