Skip to content
Snippets Groups Projects

Resolve "Resolved discussions icon is misaligned"

Merged Luke Bennett requested to merge 32683-resolved-discussions-icon-is-misaligned into master
All threads resolved!

What does this MR do?

Fix the alignment of the discussion resolution control UI

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Screen_Shot_2017-05-25_at_15.07.24

Screen_Shot_2017-05-25_at_15.07.40

Screen_Shot_2017-05-25_at_15.10.06

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #32683 (closed)

Edited by Luke Bennett

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @lbennett looks good to me! Could you just fix the scss formatting?

  • Luke Bennett resolved all discussions

    resolved all discussions

  • Luke Bennett added 1 commit

    added 1 commit

    • 6d1ac02c - Merge .line-resolve-all .line-resolve-btn duplicate reference in notes.scss

    Compare with previous version

  • Luke Bennett added 1 commit

    added 1 commit

    • ac51815a - Fix trailing space in notes.scss .line-resolve-btn

    Compare with previous version

  • Annabel Dunstone Gray approved this merge request

    approved this merge request

  • mentioned in commit 827fd034

  • mentioned in issue #33450 (closed)

  • Picked into 9-2-stable; will go into v9.2.6.

    /cc @selfup @ClemMakesApps @kushalpandya

  • mentioned in commit 9da70328

  • Please register or sign in to reply
    Loading