Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Resolve "Resolved discussions icon is misaligned"
All threads resolved!
All threads resolved!
What does this MR do?
Fix the alignment of the discussion resolution control UI
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #32683 (closed)
Edited by Luke Bennett
Merge request reports
Activity
added 1 commit
- aa3bd2ab - Correct alignment of discussion resolution control UI
changed milestone to %9.2
assigned to @lbennett
wdyt @annabeldunstone?
assigned to @annabeldunstone
added 1 commit
- 94958983 - Increase svg alignment specificity to avoid breaking inline resolve button
- Resolved by Luke Bennett
@lbennett looks good to me! Could you just fix the scss formatting?
assigned to @lbennett
added 1 commit
- 6d1ac02c - Merge .line-resolve-all .line-resolve-btn duplicate reference in notes.scss
added 1 commit
- ac51815a - Fix trailing space in notes.scss .line-resolve-btn
assigned to @annabeldunstone
LGTM! Thanks @lbennett
mentioned in commit 827fd034
mentioned in issue #33450 (closed)
Picked into
9-2-stable
; will go intov9.2.6
.mentioned in commit 9da70328
Please register or sign in to reply