Use #real_next_run in pipelines table
Closes #32509 (closed)
Merge request reports
Activity
added 1 commit
- 63e88526 - Use real_next_run in pipeline schedule table.
@zj I'm not really sure how to go about writing a spec for this change. Maybe since
real_next_run
is under test and this isn't actually a bug fix, we're covered already?Edited by Bryce Johnsonassigned to @brycepj
@brycepj Can you write test that checks what next run date is shown?
@brycepj Also, the next run date can not be in the past, so if you set the pipeline schedule up in a way that the next_run_at is in the past but the next run is in the future you should be good.
Hint, use
Timecop
to freeze the time, and don't forget to unfreeze it ;)@ayufan I just added a spec that tests for
next_run_at
in the view. https://gitlab.com/gitlab-org/gitlab-ce/commit/b3b30c947e4eda1f163436709aad35529284e82dthe next run date can not be in the past
@zj Would it make sense for unit tests of
next_run_at
to cover that, since we're just calling the method in the view?Edited by Bryce Johnsonassigned to @ayufan
@ayufan assigning to you for review.
added ~19173 Next Patch Release ~17876 labels
changed milestone to %9.2
mentioned in commit 8f1eb792
mentioned in issue #32953 (closed)
mentioned in issue #33305 (closed)
mentioned in issue #33450 (closed)
Picked into
9-2-stable
; will go intov9.2.6
.mentioned in commit 516fd01f