Enable RSpec/FilePath cop
What does this MR do?
Enable the RSpec/FilePath
cop and make it happy.
Are there points in the code the reviewer needs to double check?
For concerns, I typically describe the concern's module name, and replace described_class
with a class name. Some specs create a dummy class using the concern, others using an existing class.
I also changed some mailer, API, and routing specs to use string descriptions.
These are not strongly-held opinions
What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/31316.