Skip to content
Snippets Groups Projects

Fix orphaned notification settings

Merged James Lopez requested to merge fix/orphan-notification-settings into master
All threads resolved!

What does this MR do?

Removes any NotificationSettings that remained after their parent namespace was deleted.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/29688

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Douglas Barbosa Alexandre
  • @yorickpeterse Can you have a look, please?

  • James Lopez resolved all discussions

    resolved all discussions

  • James Lopez added 1 commit

    added 1 commit

    Compare with previous version

  • James Lopez added 1 commit

    added 1 commit

    Compare with previous version

  • James Lopez added 2 commits

    added 2 commits

    • 1c6710e2 - Add migration to remove orphaned notification settings
    • d4861ec7 - add spec and changelog

    Compare with previous version

  • Author Maintainer

    @yorickpeterse @dbalexandre updated the MR. Thanks!

  • Just so we have it in case we ever wonder: GitLab.com currently has 112 rows that will be affected by this migration.

  • Yorick Peterse changed milestone to %9.1

    changed milestone to %9.1

  • Yorick Peterse approved this merge request

    approved this merge request

  • Yorick Peterse mentioned in commit a9da3743

    mentioned in commit a9da3743

  • Yorick Peterse marked the checklist item All builds are passing as completed

    marked the checklist item All builds are passing as completed

  • Yorick Peterse marked the checklist item Branch has no merge conflicts with master (if it does - rebase it please) as completed

    marked the checklist item Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • Yorick Peterse marked the checklist item Squashed related commits together as completed

    marked the checklist item Squashed related commits together as completed

  • Author Maintainer

    This needs to go on both 9.1 and 9.0 /cc @godfat @felipe_artur @twk3

  • mentioned in issue #31059 (closed)

  • Picked into 9-1-stable, will go into 9.1.0-rc5

  • Lin Jen-Shin changed milestone to %9.0

    changed milestone to %9.0

  • Yorick Peterse mentioned in commit 6bec04ad

    mentioned in commit 6bec04ad

  • Yorick Peterse mentioned in commit 930e8c03

    mentioned in commit 930e8c03

  • Author Maintainer

    Picked into stable. Will be in 9.0.6.

  • Please register or sign in to reply
    Loading