Skip to content
Snippets Groups Projects

Fix issue's note cache expiration after delete

Merged M. Hasbini requested to merge 0xbsec/gitlab-ce:30457-expire-note-destroy into master
All threads resolved!

What does this MR do?

expire_etag_cache when a note get destroyed.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #30457 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jared Deckard
  • M. Hasbini added 1 commit

    added 1 commit

    • 21f61e0c - Fix issue's note cache expiration after delete

    Compare with previous version

  • M. Hasbini resolved all discussions

    resolved all discussions

  • @0xbsec Thanks for fixing a bug that I introduced! :green_heart:

  • Adam Niedzielski added ~164274 ~874211 labels

    added ~164274 ~874211 labels

  • Adam Niedzielski changed milestone to %9.1

    changed milestone to %9.1

  • assigned to @0xbsec

  • M. Hasbini added 739 commits

    added 739 commits

    Compare with previous version

  • M. Hasbini resolved all discussions

    resolved all discussions

  • This looks good to me!

    @smcgivern I think that we should pick this into 9.1 and probably into 9.0 (although I don't know if we have another patch release of 9.0).

  • Adam Niedzielski added ~149423 label

    added ~149423 label

  • @jameslopez are we doing another 9.0?

  • merged

  • Sean McGivern mentioned in commit 3842b654

    mentioned in commit 3842b654

  • @smcgivern I think we can (as long as the current active release is 9.0, so we've got until the 22nd). I guess we'll have to decide if we're gonna have another one soon, especially if there's something critical. I'll be off for a couple of days from tomorrow though. /cc @twk3

  • Picked into 9-1-stable, will go into 9.1.0-rc2. I'll update the milestone, and we could decide later.

  • Lin Jen-Shin changed milestone to %9.0

    changed milestone to %9.0

  • Sean McGivern mentioned in commit 2c952f8b

    mentioned in commit 2c952f8b

  • mentioned in issue #31059 (closed)

  • Picked into stable. Will be in 9.0.6.

  • Sean McGivern mentioned in commit 472c2e6a

    mentioned in commit 472c2e6a

  • Please register or sign in to reply
    Loading