Fix issue's note cache expiration after delete
What does this MR do?
expire_etag_cache
when a note get destroyed.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #30457 (closed)
Merge request reports
Activity
mentioned in issue #30457 (closed)
- Resolved by M. Hasbini
- Resolved by M. Hasbini
added 1 commit
- 21f61e0c - Fix issue's note cache expiration after delete
- Resolved by M. Hasbini
@0xbsec Thanks for fixing a bug that I introduced!
changed milestone to %9.1
assigned to @0xbsec
added 739 commits
-
21f61e0c...9c576cc7 - 738 commits from branch
gitlab-org:master
- f1f9578f - Fix issue's note cache expiration after delete
-
21f61e0c...9c576cc7 - 738 commits from branch
This looks good to me!
@smcgivern I think that we should pick this into 9.1 and probably into 9.0 (although I don't know if we have another patch release of 9.0).
assigned to @smcgivern
@jameslopez are we doing another 9.0?
Thanks @0xbsec!
mentioned in commit 3842b654
@smcgivern I think we can (as long as the current active release is 9.0, so we've got until the 22nd). I guess we'll have to decide if we're gonna have another one soon, especially if there's something critical. I'll be off for a couple of days from tomorrow though. /cc @twk3
changed milestone to %9.0
mentioned in commit 2c952f8b
mentioned in issue #31059 (closed)
mentioned in commit 472c2e6a
added devopsplan label