When signup is disabled it is not reflected in the UI
Summary
When disabling signup in the admin >> settings >> general >> signup restrictions
it is not reflected in the UI in the admin dashboard. Sign up appears to have a green bubble beside it.No errors in the developer tools, behavior changed for a customer once they upgraded 12.0.0-ee to 12.2.1-ee.
Good chance that it was introduced here: https://gitlab.com/gitlab-org/gitlab-ce/commit/a6ac0a2765f07348f618076b8e550e29c9675b77
irb(main):003:0> ApplicationSetting.last.signup_enabled
=> false
irb(main):004:0>
<h4>Features</h4>
<p aria-label="Sign up: status on"><a href="/admin/application_settings#js-signup-settings">Sign up</a><span class="light float-right"><i aria-hidden="true" data-hidden="true" class="fa fa-circle cgreen"></i></span></p>
Steps to reproduce
Disable sign up in the admin >> settings >> general >> signup restrictions
and check the admin dashboard.
What is the expected correct behavior?
When signup is disabled it should not show green bubble in the admin dashboard.
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 16.04 Proxy: no Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.22.0 Sidekiq Version:5.2.7 Go Version: unknownGitLab information Version: 12.2.1-ee Revision: e4a8b6c773a Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.9 URL: http://167.71.37.171 HTTP Clone URL: http://167.71.37.171/some-group/some-project.git SSH Clone URL: git@167.71.37.171:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers:
Results of GitLab application Check
Expand for output related to the GitLab application check
N/A
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
cc @xanf