Proposal: Remove area chart in favor of time series
Summary
TimeSeries.vue
chart component supports both area and line charts, and contains the functionality of the previous Area.vue
.
Objective: Decide if we should remove Area.vue
from https://gitlab.com/gitlab-org/gitlab-ee/tree/master/app/assets/javascripts/monitoring/components/charts
Details
In 2 issues support for line charts is added:
- https://gitlab.com/gitlab-org/gitlab-ce/issues/65412
- https://gitlab.com/gitlab-org/gitlab-ce/issues/66073
This was done by repurposing a lot of the area charts functions and moving them to a new component called Time Series, which accounts for both line and area charts.
This might make Area.vue
chart obsolete, and could be removed.
MR links:
- New time series component https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31639
- Area is not used anymore here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31920#note_205982108)
Edited by Miguel Rincon