Remove FE references to class `descr`
Description
It looks like this class doesn't actually do anything. There's one spec where we look for this, but since this class isn't styled it should prefix it with js-
. I'm guessing this class spread because other copied the one that originally needed it
Analysis
git grep -e '\Wdescr\W' | pbcopy
app/assets/stylesheets/framework/variables.scss:$project-option-descr-color: #54565b;
app/assets/stylesheets/pages/settings.scss: color: $project-option-descr-color;
app/assets/stylesheets/pages/settings.scss: color: $project-option-descr-color;
app/views/groups/_group_admin_settings.html.haml: %span.descr This setting can be overridden in each project.
app/views/groups/settings/_permissions.html.haml: %span.descr.text-muted= share_with_group_lock_help_text(@group)
app/views/projects/_merge_request_merge_checks_settings.html.haml: .descr.text-secondary
app/views/projects/_merge_request_merge_method_settings.html.haml: .descr.text-secondary
app/views/projects/_merge_request_merge_method_settings.html.haml: .descr.text-secondary
app/views/projects/_merge_request_merge_method_settings.html.haml: .descr.text-secondary
ee/app/views/projects/_merge_pipelines_settings.html.haml: .descr.text-secondary.mb-2
spec/views/groups/edit.html.haml_spec.rb: expect(rendered).to have_css('.descr', text: 'help text here')
Context
The following discussion from !30961 (merged) should be addressed:
-
@pslaughter started a discussion: (+4 comments) nitpick: It looks like
.descr
doesn't actually do anything... Can we remove it?