Follow-up from "Wiki Usage Ping for Create SMAU"
The following discussions from !30864 (merged) should be addressed:
-
@alexkalderimis started a discussion: This test became redundant since what it is trying to check is now subsumed in the
web_ide_counter_spec.rb
- i.e. that each total is correctly called and reported.Ideally this should be tested at the counter level, and we shouldn't leak internal details into this class.
-
@fjsanpedro started a discussion: (+1 comment) @alexkalderimis I guess we should create a method
totals
inRedisCounter
since now that method is shared among all the counters, and each one of them should implement it.WDYT?
Basically we ought to decide what the interface of usage counters should be, and how they should be implemented in the future.