Merge request does not show all changed files, showing whitespace changes is not working properly
Summary
We found out that in our merge request not all changed files where shown in the file browser.
Further investigation has shown, that showing the changed files depends on the setting Show whitespace changes
.
If checked (the default setting) most of the files are not shown, even though the changes are more then whitespaces. I unchecked all changed files are shown in the file browser.
Steps to reproduce
Don't know. Are MR consisted of a lot of deleted files.
What is the current bug behavior?
File browser is not showing all the changed files. File changes which are more then whitespace changes are not shown when
Show whitespace changes
is activated. When deactivated, all changed files are shown.
What is the expected correct behavior?
File browser is showing all the files, no matter if Show whitespace changes
is checked or not.
Relevant logs and/or screenshots
Default view, files are missing in the file explorer (Show whitespace changes
activated):
Files are shown in the file explorer (Show whitespace changes
deactivated):
File LDO.sch has more then whitespace changes. Both images show same MR.
Results of GitLab environment info
Expand for output related to GitLab environment info
╰─# gitlab-rake gitlab:env:info
System information System: Ubuntu 18.04 Current User: gitlab Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.21.0 Sidekiq Version:5.2.7 Go Version: unknown
GitLab information Version: 12.0.3 Revision: 08a51a9db93 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.7 URL: https://gitlab:8000 HTTP Clone URL: https://gitlab:8000/some-group/some-project.git SSH Clone URL: gitlab@gitlab:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 9.3.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 9.3.0 ? ... OK (9.3.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 110/4 ... yes 110/5 ... yes 112/6 ... yes 110/7 ... yes 199/9 ... yes 116/10 ... yes 115/11 ... yes 199/12 ... yes 231/13 ... yes 104/15 ... yes 104/16 ... yes 2/17 ... yes 112/19 ... yes 110/20 ... yes 202/21 ... yes 113/22 ... yes 202/23 ... yes 113/24 ... yes 113/25 ... yes 20/26 ... yes 48/27 ... yes 48/28 ... yes 105/29 ... yes 105/30 ... yes 105/31 ... yes 113/32 ... yes 112/33 ... yes 112/34 ... yes 103/35 ... yes 231/36 ... yes 108/37 ... yes 108/38 ... yes 108/39 ... yes 108/40 ... yes 108/41 ... yes 108/42 ... yes 108/43 ... yes 109/44 ... yes 109/45 ... yes 109/46 ... yes 88/47 ... yes 88/48 ... yes 112/50 ... yes 113/51 ... yes 113/52 ... yes 113/53 ... yes 108/55 ... yes 108/56 ... yes 108/58 ... yes 4/60 ... yes 108/61 ... yes 108/62 ... yes 88/63 ... yes 88/64 ... yes 117/65 ... yes 117/66 ... yes 117/67 ... yes 109/70 ... yes 167/71 ... yes 109/72 ... yes 7/73 ... yes 109/74 ... yes 112/76 ... yes 81/77 ... yes 108/78 ... yes 97/82 ... yes 99/84 ... yes 40/85 ... yes 90/86 ... yes 40/87 ... yes 90/89 ... yes 90/90 ... yes 90/91 ... yes 90/92 ... yes 108/93 ... yes 108/94 ... yes 108/95 ... yes 108/96 ... yes 108/97 ... yes 108/98 ... yes 108/99 ... yes 108/100 ... yes 250/102 ... yes 50/103 ... yes 48/104 ... yes 49/106 ... yes 253/107 ... yes 252/109 ... yes 251/110 ... yes 254/111 ... yes 49/112 ... yes 49/113 ... yes 255/114 ... yes 49/115 ... yes 256/116 ... yes 250/117 ... yes 259/118 ... yes 50/119 ... yes 50/120 ... yes 50/121 ... yes 50/122 ... yes 50/123 ... yes 50/124 ... yes 50/125 ... yes 50/126 ... yes 50/127 ... yes 50/128 ... yes 50/129 ... yes 50/130 ... yes 50/131 ... yes 48/132 ... yes 48/133 ... yes 48/134 ... yes 49/135 ... yes 108/136 ... yes 188/143 ... yes 102/144 ... yes 102/145 ... yes 102/146 ... yes 102/147 ... yes 102/148 ... yes 95/150 ... yes 142/151 ... yes 94/152 ... yes 234/153 ... yes 67/154 ... yes 67/155 ... yes 67/156 ... yes 67/157 ... yes 93/158 ... yes 108/159 ... yes 40/160 ... yes 109/161 ... yes 65/162 ... yes 235/163 ... yes 241/165 ... yes 240/167 ... yes 95/168 ... yes 240/169 ... yes 234/170 ... yes 81/171 ... yes 76/172 ... yes 93/173 ... yes 240/174 ... yes 93/175 ... yes 76/178 ... yes 191/179 ... yes 94/182 ... yes 241/183 ... yes 90/184 ... yes 237/185 ... yes 67/186 ... yes 50/187 ... yes 109/188 ... yes 108/189 ... yes 4/190 ... yes 125/192 ... yes 230/193 ... yes 125/194 ... yes 103/195 ... yes 109/196 ... yes 187/197 ... yes 125/198 ... yes 108/199 ... yes 108/200 ... yes 108/201 ... yes 244/203 ... yes 108/204 ... yes 40/205 ... yes 125/206 ... yes 125/207 ... yes 69/208 ... yes 108/209 ... yes 94/210 ... yes 125/211 ... yes 125/212 ... yes 108/213 ... yes 108/214 ... yes 233/216 ... yes 145/217 ... yes 167/218 ... yes 131/220 ... yes 94/221 ... yes 94/222 ... yes 108/223 ... yes 94/224 ... yes 94/225 ... yes 231/226 ... yes 31/227 ... yes 132/228 ... yes 105/229 ... yes 109/230 ... yes 236/232 ... yes 108/233 ... yes 108/234 ... yes 108/235 ... yes 131/236 ... yes 131/237 ... yes 108/238 ... yes 121/239 ... yes 167/240 ... yes 167/241 ... yes 258/242 ... yes 136/243 ... yes 136/244 ... yes 136/245 ... yes 136/246 ... yes 136/247 ... yes 136/248 ... yes 262/249 ... yes 280/250 ... yes 136/251 ... yes 136/252 ... yes 139/253 ... yes 281/255 ... yes 279/259 ... yes 273/260 ... yes 276/261 ... yes 265/264 ... yes 138/266 ... yes 275/267 ... yes 167/269 ... yes 167/270 ... yes 73/271 ... yes 139/273 ... yes 132/274 ... yes 253/275 ... yes 30/276 ... yes 132/277 ... yes 25/278 ... yes 139/280 ... yes 259/282 ... yes 239/283 ... yes 167/284 ... yes 94/285 ... yes 245/286 ... yes 150/287 ... yes 150/288 ... yes 150/289 ... yes 150/290 ... yes 150/291 ... yes 151/292 ... yes 151/293 ... yes 152/294 ... yes 152/295 ... yes 162/296 ... yes 162/297 ... yes 162/298 ... yes 162/299 ... yes 163/300 ... yes 163/301 ... yes 148/303 ... yes 269/304 ... yes 62/305 ... yes 155/306 ... yes 238/307 ... yes 156/308 ... yes 285/309 ... yes 288/310 ... yes 287/311 ... yes 286/312 ... yes 284/313 ... yes 157/314 ... yes 157/315 ... yes 157/316 ... yes 157/317 ... yes 94/318 ... yes 139/319 ... yes 137/320 ... yes 155/321 ... yes 62/322 ... yes 94/323 ... yes 161/325 ... yes 161/326 ... yes 161/327 ... yes 161/328 ... yes 161/329 ... yes 161/330 ... yes 161/331 ... yes 161/332 ... yes 164/333 ... yes 164/334 ... yes 164/335 ... yes 164/336 ... yes 164/337 ... yes 167/338 ... yes 4/339 ... yes 277/340 ... yes 139/341 ... yes 132/342 ... yes 4/343 ... yes 165/345 ... yes 165/346 ... yes 165/347 ... yes 165/348 ... yes 165/349 ... yes 165/350 ... yes 167/351 ... yes 168/352 ... yes 168/353 ... yes 168/354 ... yes 168/355 ... yes 168/356 ... yes 169/358 ... yes 169/359 ... yes 169/360 ... yes 165/361 ... yes 165/362 ... yes 165/363 ... yes 166/364 ... yes 299/365 ... yes 299/366 ... yes 299/367 ... yes 299/368 ... yes 299/369 ... yes 299/370 ... yes 299/371 ... yes 299/372 ... yes 299/373 ... yes 299/374 ... yes 299/375 ... yes 299/376 ... yes 299/377 ... yes 299/378 ... yes 299/379 ... yes 299/380 ... yes 299/381 ... yes 272/382 ... yes 241/383 ... yes 241/384 ... yes 136/385 ... yes 88/387 ... yes 173/388 ... yes 167/389 ... yes 88/390 ... yes 88/391 ... yes 241/392 ... yes 88/393 ... yes 299/394 ... yes 90/395 ... yes 90/396 ... yes 90/397 ... yes 90/398 ... yes 142/400 ... yes 125/401 ... yes 125/402 ... yes 125/403 ... yes 264/404 ... yes 270/405 ... yes 278/406 ... yes 139/407 ... yes 139/408 ... yes 176/411 ... yes 176/412 ... yes 241/414 ... yes 109/415 ... yes 241/416 ... yes 203/417 ... yes 203/418 ... yes 131/419 ... yes 62/420 ... yes 50/421 ... yes 181/422 ... yes 181/423 ... yes 181/424 ... yes 137/425 ... yes 274/426 ... yes 167/427 ... yes 241/430 ... yes 241/431 ... yes 26/432 ... yes 105/433 ... yes 95/434 ... yes 301/435 ... yes 301/436 ... yes 301/437 ... yes 301/438 ... yes 301/439 ... yes 241/440 ... yes 232/441 ... yes 94/442 ... yes 164/443 ... yes 108/444 ... yes 241/445 ... yes 67/446 ... yes 194/447 ... yes 167/448 ... yes 241/449 ... yes 203/450 ... yes 203/451 ... yes 246/452 ... yes 246/453 ... yes 197/454 ... yes 165/455 ... yes 94/456 ... yes 164/457 ... yes 164/458 ... yes 164/459 ... yes 164/460 ... yes 167/461 ... yes 164/462 ... yes 164/463 ... yes 164/464 ... yes 167/465 ... yes 164/466 ... yes 164/467 ... yes 247/469 ... yes 248/471 ... yes 248/478 ... yes 165/480 ... yes 251/485 ... yes 263/486 ... yes 258/487 ... yes 291/488 ... yes 263/489 ... yes 284/490 ... yes 285/491 ... yes 286/492 ... yes 287/493 ... yes 288/494 ... yes 290/495 ... yes 281/496 ... yes 165/497 ... yes 263/498 ... yes 264/499 ... yes 291/500 ... yes 291/501 ... yes 165/502 ... yes 292/503 ... yes 294/504 ... yes 72/505 ... yes 277/506 ... yes 295/507 ... yes 295/508 ... yes 136/509 ... yes 300/510 ... yes 300/511 ... yes 300/512 ... yes 300/513 ... yes 300/514 ... yes 300/515 ... yes 300/516 ... yes 265/517 ... yes 298/518 ... yes 298/519 ... yes 252/520 ... yes 302/521 ... yes 302/522 ... yes 302/523 ... yes 302/524 ... yes 302/525 ... yes 302/526 ... yes 302/527 ... yes 302/528 ... yes 302/529 ... yes 302/530 ... yes 167/531 ... yes 167/532 ... yes 303/533 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.21.0 ? ... yes (2.21.0) Git user has default SSH configuration? ... yes Active users: ... 28
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished