Update sizes used in the loading icon (spinner) component
Problem
Currently, the loading icon (spinner) component implemented across the product is using deprecated sizes (1, 2, 3, 4, and 5).
Copying some notes from gitlab-ui!614 (merged):
Currently, the most used size, across 119 component instances, is
2andmdwhich will be changed tolgonce gitlab-ui#308 (closed) gets implemented. The rest instances are using the default size which wasmd, right?
| Size | How many instances? |
|---|---|
1 |
0 |
2 |
20 |
3 |
9 |
4 |
1 |
5 |
0 |
sm |
6 |
md |
15 |
lg |
0 |
Proposal
- Replace all sizes from
2tolg. - Replace all sizes from
2also tolg. - Replace all sizes from
4toxl. - Change all
mdsizes tolg.
Risks
Just have to verify step 2 is not affecting negatively the UX.
Replace all sizes from
2also tolg.
Before closing / Next steps
Once the steps above have been completed, proceed with opening a follow-up issue to remove support for legacy sizes. See relevant discussion in gitlab-ui!633 (comment 195902770).
See also additional notes in loading_icon.md and specs to be removed in loading_icon.spec.js