File Diff Header Hides Changed Files Popover
Summary
The file diff components header bar hides the files changes popover, when you click to view the files changes, on a commit page. This leads to the files changes search box being hidden. This appears to be due to the change to the z-index of .diff-file .file-title-flex-parent
which came in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29473
Steps to reproduce
- Navigate to a commit diff page
- Click the files changed dropdown icon.
- The first file diff will overlay the popover.
What is the current bug behavior?
The first file diff on the commit page, hides the search box in the files changes popover.
What is the expected correct behavior?
The files changed popover overlays everything on the page.
Relevant logs and/or screenshots
Possible fixes
Set z-index: 199
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/stylesheets/pages/diff.scss#L17