Update recommendation to use node@12
Node@12 seems to have significant performance improvements:
| Node 10: Execution time in seconds | Node 12: Execution time in seconds | Saved time | |
|---|---|---|---|
| yarn run webpack | 41,37 ± 1,35 | 30,88 ± 3,13 | 25,35 % |
| yarn run webpack-prod | 868,08 ± 48,49 | 506,54 ± 26,34 | 41,65 % |
(Memory usage was about the same)
Thus it would make sense to make it the recommended version for development and use it as a default in CI.
To do that we need to:
-
New Build images: gitlab-build-images!197 (merged) -
Using the new Build images and updating docs in CE: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29659 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29703 -
GitLab UI: gitlab-ui!564 (merged) -
GitLab SVGs: gitlab-svgs!460 (merged) -
design.gitlab.com: https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1428 -
Updating the node installation instructions in the GDK: gitlab-development-kit!698 (merged) -
gitlab-omnibus builder: gitlab-omnibus-builder!109 (closed) -
CNG: gitlab-org/build/CNG!234 (merged) -
Removing the old images from our build plan: gitlab-build-images!198 (merged) -
Announcing it in company call and appropriate engineering slack channels
Edited by DJ Mountney