Instance statistics don't hide
Summary
The Instance Statistics button in the first-level navigation UI isn't hidden when disabling the Usage Ping feature.
Steps to reproduce
Disable the Usage Ping, as explained at https://docs.gitlab.com/ee/user/admin_area/settings/usage_statistics.html#deactivate-the-usage-ping
What is the current bug behavior?
See Summary
What is the expected correct behavior?
The button isn't shown.
I feel like the statistics presented here are not useful and definitely do not deserve a first-level UI element.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Proxy: no Current User: git Using RVM: no Ruby Version: 2.5.3p105 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.21.0 Sidekiq Version:5.2.7 Go Version: unknownGitLab information Version: 11.11.0-ee Revision: deb6f84e91f Directory: /data/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 9.6.11 URL: https://… HTTP Clone URL: https://…/some-group/some-project.git SSH Clone URL: git@…:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 9.1.0 Repository storage paths:
- default: /data/gitlab-opt/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)