No error message displayed when updating project general settings
Summary
In Settings > General
, when updating a project name to something including a disallowed character, the form simply refreshes without displaying the validation error.
Steps to reproduce
- Go to
Settings > General
in a project - Update the "Project name" field to
Test Title (Something in brackets)
- Click "Save changes"
- See that update is not made, nor is error displayed
Example Project
Any project.
What is the current bug behavior?
When attempting to save with a validation error, the backend returns the error (see AJAX response below). However, the frontend does not display this error to the user.
What is the expected correct behavior?
The frontend should display the error which the AJAX request returned.
Relevant logs and/or screenshots
Response from POST https://gitlab.com/group/project
endpoint:
$(".project-edit-errors").html("<div class=\"alert alert-danger\" id=\"error_explanation\"><h4>The form contains the following error:<\/h4><ul><li>Name can contain only letters, digits, emojis, '_', '.', dash, space. It must start with letter, digit, emoji or '_'.<\/li><\/ul><\/div>\n");
$('.save-project-loader').hide();
$('.project-edit-container').show();
$('.edit-project .js-btn-success-general-project-settings').enable();
Output of checks
This bug happens on GitLab.com.