Gitaly panics
Gitaly has a bug that causes it to panic. The bug was introduced in gitaly@31248fb7.
the logs show:
panic: interface conversion: interface {} is catfile.CacheItem, not *catfile.CacheItem
goroutine 461 [running]:
gitlab.com/gitlab-org/gitaly/internal/git/catfile.(*BatchCache).Add(0xc0001a4290, 0xc00003c750, 0x24, 0xc00025ec40, 0x7, 0xc000043e60, 0x52, 0x0, 0x0, 0x0, ...)
/Users/johncai/go/src/gitlab.com/gitlab-org/gitaly/_build/src/gitlab.com/gitlab-org/gitaly/internal/git/catfile/batch_cache.go:118 +0x362
gitlab.com/gitlab-org/gitaly/internal/git/catfile.(*BatchCache).returnToCache(0xc0001a4290, 0x1a85c60, 0xc0006c2ab0, 0xc00003c750, 0x24, 0xc00025ec40, 0x7, 0xc000043e60, 0x52, 0x0, ...)
/Users/johncai/go/src/gitlab.com/gitlab-org/gitaly/_build/src/gitlab.com/gitlab-org/gitaly/internal/git/catfile/batch_cache.go:164 +0xdf
created by gitlab.com/gitlab-org/gitaly/internal/git/catfile.New.func1
/Users/johncai/go/src/gitlab.com/gitlab-org/gitaly/_build/src/gitlab.com/gitlab-org/gitaly/internal/git/catfile/catfile.go:164 +0x9d
panic: interface conversion: interface {} is catfile.CacheItem, not *catfile.CacheItem
fixed by: gitaly!1234 (merged)
Edited by John Cai