MR diff note can get outdated more frequently when leaving comments in expanded files
Note that gitlab-com/www-gitlab-com!21648 (comment 165040139) comment was made at 0de6a258a8e95d82a2f4d25c2538ef04eb3fef3d, and the commit history has only one commit ahead of it, which is 61bd2174717dd9982358d89cdd9266344d3c9fb0.
This latter commit doesn't change
source/direction/verify/system_testing/index.html.md, though, the comment at it got outdated. By outdating the note, the suggestion also cannot be applied.
What probably happened is that the
Gitlab::Diff::PositionTracer were not able to find the commented line in the latest version, because it was made in an expanded line (
I believe it should consider expanding the lines with the
Gitlab::Diff::LinesUnfolder before making any assumption to outdate the comment.
Does that sound reasonable @DouweM?