Fix the `stylelint-gitlab/duplicate-selectors` style-lint errors and warnings for `app/assets/stylesheets/pages/notes.scss`
Problem
Fix the following style-lint errors and warnings for app/assets/stylesheets/pages/notes.scss
67:7 ⚠ ".timeline-content" and "&.note-form (app/assets/stylesheets/pages/notes.scss -54:5)" have the same properties. stylelint-gitlab/duplicate-selectors
79:5 ⚠ ".card" and "&.system-note, &.note-form (app/assets/stylesheets/pages/notes.scss -49:5)" have the same properties. stylelint-gitlab/duplicate-selectors
96:5 ⚠ "&.expanded" and "li.note (app/assets/stylesheets/pages/notes.scss -84:3)" have the same properties. stylelint-gitlab/duplicate-selectors
198:7 ⚠ ".note-timestamp" and ".editing-spinner (app/assets/stylesheets/pages/notes.scss -193:5)" have the same properties. stylelint-gitlab/duplicate-selectors
208:7 ⚠ ".note-header, .note-text, .edited-text" and ".note-timestamp (app/assets/stylesheets/pages/notes.scss stylelint-gitlab/duplicate-selectors
-198:7)" have the same properties.
217:9 ⚠ "&.current-note-edit-form + .note-awards" and ".note-header, .note-text, .edited-text stylelint-gitlab/duplicate-selectors
(app/assets/stylesheets/pages/notes.scss -208:7)" have the same properties.
250:7 ⚠ ".fa-spinner" and "&.current-note-edit-form + .note-awards (app/assets/stylesheets/pages/notes.scss -217:9)" have the same stylelint-gitlab/duplicate-selectors
properties.
255:9 ⚠ ".fa-smile-o" and ".fa-spinner (app/assets/stylesheets/pages/notes.scss -250:7)" have the same properties. stylelint-gitlab/duplicate-selectors
259:9 ⚠ ".fa-spinner" and ".editing-spinner (app/assets/stylesheets/pages/notes.scss -202:7)" have the same properties. stylelint-gitlab/duplicate-selectors
304:5 ⚠ ".note-header" and ".note-header-info (app/assets/stylesheets/pages/notes.scss -271:5)" have the same properties. stylelint-gitlab/duplicate-selectors
439:5 ⚠ ".add-diff-note" and ".fa-spinner (app/assets/stylesheets/pages/notes.scss -259:9)" have the same properties. stylelint-gitlab/duplicate-selectors
516:3 ⚠ ".notes_content" and ".notes (app/assets/stylesheets/pages/notes.scss -483:9)" have the same properties. stylelint-gitlab/duplicate-selectors
540:3 ⚠ ".author-link" and ".author-link (app/assets/stylesheets/pages/notes.scss -124:7)" have the same properties. stylelint-gitlab/duplicate-selectors
548:3 ⚠ ".note-header-info" and ".note-header (app/assets/stylesheets/pages/notes.scss -304:5)" have the same properties. stylelint-gitlab/duplicate-selectors
552:3 ⚠ ".timeline-content" and ".note-body (app/assets/stylesheets/pages/notes.scss -223:5)" have the same properties. stylelint-gitlab/duplicate-selectors
559:3 ⚠ ".note-header-info" and ".note-body (app/assets/stylesheets/pages/notes.scss -161:7)" have the same properties. stylelint-gitlab/duplicate-selectors
573:3 ⚠ "&.discussion" and ".note-header-info (app/assets/stylesheets/pages/notes.scss -548:3)" have the same properties. stylelint-gitlab/duplicate-selectors
578:1 ⚠ ".system-note .note-header-info" and "&.discussion (app/assets/stylesheets/pages/notes.scss -573:3)" have the same stylelint-gitlab/duplicate-selectors
properties.
590:1 ⚠ ".note-headline-light, .discussion-headline-light" and "&.collapsed (app/assets/stylesheets/pages/notes.scss -109:5)" have stylelint-gitlab/duplicate-selectors
the same properties.
596:3 ⚠ "a" and "a (app/assets/stylesheets/pages/notes.scss -284:7)" have the same properties. stylelint-gitlab/duplicate-selectors
655:3 ⚠ ".tooltip" and ".note-timestamp (app/assets/stylesheets/pages/notes.scss -606:3)" have the same properties. stylelint-gitlab/duplicate-selectors
758:3 ⚠ "a" and "a (app/assets/stylesheets/pages/notes.scss -596:3)" have the same properties. stylelint-gitlab/duplicate-selectors
768:3 ⚠ "> div" and ".tooltip (app/assets/stylesheets/pages/notes.scss -655:3)" have the same properties. stylelint-gitlab/duplicate-selectors
876:9 ⚠ "> .timeline-content" and ".timeline-content (app/assets/stylesheets/pages/notes.scss -67:7)" have the same properties. stylelint-gitlab/duplicate-selectors
880:9 ⚠ "> .timeline-icon" and ".fa-smile-o (app/assets/stylesheets/pages/notes.scss -255:9)" have the same properties. stylelint-gitlab/duplicate-selectors
888:9 ⚠ ".discussion-wrapper" and ".card (app/assets/stylesheets/pages/notes.scss -79:5)" have the same properties. stylelint-gitlab/duplicate-selectors
895:3 ⚠ ".diff-comment-form" and ".note-edit-form (app/assets/stylesheets/pages/notes.scss -214:7)" have the same properties. stylelint-gitlab/duplicate-selectors
931:3 ⚠ ".discussion-form-container" and ".note-wrapper (app/assets/stylesheets/pages/notes.scss -22:1)" have the same properties. stylelint-gitlab/duplicate-selectors
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
- Double check if all the warning have been fixed by running
yarn run stylelint-file
app/assets/stylesheets/pages/notes.scss` - In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/
folder. You can read more about how to handle EE code here - Label the MR with CSS cleanup
Edited by Denys Mishunov