Possible bug with using Knative Prometheus metrics if you install both Knative and Prometheus at the same time
Summary
I think looking at the code we may run into an issue since it won't install the metrics postinstall
under those circumstances. Our UI does allow you to click install on both at the same time. Here I think the code may not be right:
- https://gitlab.com/gitlab-org/gitlab-ce/blob/feec8770c7706ebf439cf7787fccb3fe3a731c33/app/models/clusters/applications/prometheus.rb
- https://gitlab.com/gitlab-org/gitlab-ce/blob/feec8770c7706ebf439cf7787fccb3fe3a731c33/app/models/clusters/applications/knative.rb
Steps to reproduce
- Create a project, add cluster, install helm
- Click
Install
on Prometheus and before that is finished clickInstall
on Knative - Wait for both to finish
- Deploy a function
- Make some requests to that function
- You will not see any metrics on the
Operations > Serverless
page since the Prometheus metrics have not been installed on the cluster.
Example Project
What is the current bug behavior?
What is the expected correct behavior?
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Results of GitLab application Check
Possible fixes
Edited by Dylan Griffith