Fix dropdown menu CSS to permit links and buttons to co-exist
The following comment should be addressed !27275 (comment 160467439):
Clever patch to get buttons working in this dropdown without causing unintended side-effects!
I'm okay with doing this for now, but I'd like to create a follow up issue to address some concerns. Patches like this are a sign that there's something wrong happening...
.btnin this dropdown menu to actually be styled as buttons, but we have some preexisting style rules which want them to be dropdown links.
@patrickbajao's patch?What's great about
This change only effects the elements of this feature, so there is a pretty low risk of unrelated regressions
What's wrong with this patch?
This change adds an even more specific selector to beat a less specific selector
.dropdown-menu li awhich beat
.btn. Unfortunately, this patch will silently break when an even more specific selector comes along
What's the real problem?
We are abusing semantics in
_download.html.hamlby having every block (i.e. header, content, seprator) be a
<li>. We should only use
<li>for things that are actually lists. Otherwise, issues like this come up.