Web IDE only queries Gravatar and ignores avatars uploaded to GitLab
Summary
GitLab Web IDE only shows Gravatar avatars if they are enabled. Avatars uploaded into GitLab via profile pages are ignored.
Steps to reproduce
- Create project on GitLab CE instance 11.9.6-ce.0.
- Disable Gravatar in instance settings.
- Add own avatar for user account via profile page.
- Commit to new project using a mail address of the current user account.
- Check footer line of Web IDE.
- You will see a dummy image and not your uploaded avatar.
Example Project
Difficult, because you need write access to repository to work with Web IDE; follow steps above.
What is the current bug behavior?
Dummy avatar shown.
What is the expected correct behavior?
Show uploaded GitLab avatar.
Relevant logs and/or screenshots
CE with disabled Grvatar:
GitLab.com with not Gravatar avatar set for mail address:
Output of checks
This bug also happens on GitLab.com if you not set a Gravatar avatar for your mail account.
Results of GitLab environment info
Also on GitLab.com
Results of GitLab application Check
Also on GitLab.com
Possible fixes
It seems that we only query Gravatar avatars for WebIDE: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/serializers/commit_entity.rb#L9