Fix the following style-lint errors and warnings for `app/assets/stylesheets/pages/search.scss`
Problem
Fix the following style-lint errors and warnings for app/assets/stylesheets/pages/search.scss
39:5 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
125:7 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
134:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
134:9 ⚠ Expected ".search.search-active form .search-input-wrap .search-icon" to have no more than 3 compound selectors selector-max-compound-selectors
134:9 ⚠ Expected ".search.search-active form .search-input-wrap .clear-icon" to have no more than 3 compound selectors selector-max-compound-selectors
153:5 ⚠ ".search-icon" and ".clear-icon (app/assets/stylesheets/pages/search.scss -90:5)" have the same properties. stylelint-gitlab/duplicate-selectors
233:3 ⚠ ".dropdown-menu-toggle" and ".btn-search, .btn-success (app/assets/stylesheets/pages/search.scss -214:3)" have the same stylelint-gitlab/duplicate-selectors
properties.
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
- Double check if all the warning have been fixed by running
yarn run stylelint-file app/assets/stylesheets/pages/search.scss
- In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/
folder. You can read more about how to handle EE code here - Label the MR with CSS cleanup