Fix the following style-lint errors and warnings for `app/assets/stylesheets/pages/editor.scss`
Problem
Fix the following style-lint errors and warnings for app/assets/stylesheets/pages/editor.scss
21:3 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
34:5 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
89:7 ⚠ ".soft-wrap" and ".no-wrap (/Users/filipalacerda/Documents/git/gitlab-development-kit/gitlab/app/assets/stylesheets/pages/editor.scss -84:5)" have the same properties. stylelint-gitlab/duplicate-selectors
93:7 ⚠ ".no-wrap" and ".soft-wrap (/Users/filipalacerda/Documents/git/gitlab-development-kit/gitlab/app/assets/stylesheets/pages/editor.scss -80:5)" have the same properties. stylelint-gitlab/duplicate-selectors
103:5 ⚠ ".file-title" and ".no-wrap (/Users/filipalacerda/Documents/git/gitlab-development-kit/gitlab/app/assets/stylesheets/pages/editor.scss -93:7)" have the same properties. stylelint-gitlab/duplicate-selectors
127:9 ⚠ Expected ".file-editor .file-buttons .encoding-selector button" to have no more than 3 compound selectors selector-max-compound-selectors
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
- Double check if all the warning have been fixed by running
yarn run stylelint-file app/assets/stylesheets/pages/editor.scss
- In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/
folder. You can read more about how to handle EE code here - Label the MR with CSS cleanup