Fix the following style-lint errors and warnings for `app/assets/stylesheets/mailers/highlighted_diff_email.scss`
Problem
Fix the following style-lint errors and warnings for app/assets/stylesheets/mailers/highlighted_diff_email.scss
109:1 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
116:5 ⚠ Expected ".line_content.old > .line > span > span.idiff" to have no more than 3 compound selectors selector-max-compound-selectors
125:5 ⚠ Expected ".line_content.new > .line > span > span.idiff" to have no more than 3 compound selectors selector-max-compound-selectors
149:5 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
161:1 ⚠ ".o" and ".k (app/assets/stylesheets/mailers/highlighted_diff_email.scss -160:1)" have the same properties. stylelint-gitlab/duplicate-selectors
202:1 ⚠ ".gs" and ".o (app/assets/stylesheets/mailers/highlighted_diff_email.scss -161:1)" have the same properties. stylelint-gitlab/duplicate-selectors
207:1 ⚠ ".kc" and ".gs (app/assets/stylesheets/mailers/highlighted_diff_email.scss -202:1)" have the same properties. stylelint-gitlab/duplicate-selectors
208:1 ⚠ ".kd" and ".kc (app/assets/stylesheets/mailers/highlighted_diff_email.scss -207:1)" have the same properties. stylelint-gitlab/duplicate-selectors
209:1 ⚠ ".kn" and ".kd (app/assets/stylesheets/mailers/highlighted_diff_email.scss -208:1)" have the same properties. stylelint-gitlab/duplicate-selectors
210:1 ⚠ ".kp" and ".kn (app/assets/stylesheets/mailers/highlighted_diff_email.scss -209:1)" have the same properties. stylelint-gitlab/duplicate-selectors
211:1 ⚠ ".kr" and ".kp (app/assets/stylesheets/mailers/highlighted_diff_email.scss -210:1)" have the same properties. stylelint-gitlab/duplicate-selectors
234:1 ⚠ ".ow" and ".kr (app/assets/stylesheets/mailers/highlighted_diff_email.scss -211:1)" have the same properties. stylelint-gitlab/duplicate-selectors
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
- Double check if all the warning have been fixed by running
yarn run stylelint-file app/assets/stylesheets/mailers/highlighted_diff_email.scss
- In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/
folder. You can read more about how to handle EE code here - Label the MR with CSS cleanup
Edited by Filipa Lacerda