"Reply by Email" domain no more following incoming_email_address
Summary
Emails sent by our GitLab 11.9.1-ce.0 (Omnibus install) are no more sent from the configured domain:
gitlab_rails['incoming_email_address'] = "gitlab+%{key}@gitlab.example.com"
We receive mails with a Reply-To:
header set to gitlab+key@example.com
instead of gitlab+key@gitlab.example.com
.
It was OK "before" (I cannot say exactly when it broke, maybe from the recent upgrades to 11.8 or 11.9?)
Steps to reproduce
Add a comment to any issue. GitLab send a notification by email to other members with a Reply-To:
header set.
What is the current bug behavior?
Notification emails are sent with Reply-To:
set to gitlab+key@example.com
.
What is the expected correct behavior?
Notification emails must be (and were) sent with Reply-To:
set to gitlab+key@gitlab.example.com
.
Relevant logs and/or screenshots
Example of an email received. Some headers seems correctly formed (but the server's hostname is gitlab.example.com
, so it may not be related), but not Reply-To:
:
[...]
Date: Fri, 29 Mar 2019 15:48:29 +0100
From: User <gitlab@example.com>
Reply-To: Project <gitlab+7d6c6d07a15f85d3a435f07930a7ecbb@example.com>
To: me@example.com
Message-ID: <note_1881@gitlab.example.com>
In-Reply-To: <issue_463@gitlab.example.com>
References: <reply-7d6c6d07a15f85d3a435f07930a7ecbb@gitlab.example.com>
<issue_463@gitlab.example.com>
[...]
List-Unsubscribe: <https://gitlab.example.com/sent_notifications/REDACTED/unsubscribe?force=true>,<mailto:gitlab+7d6c6d07a15f85d3a435f07930a7ecbb-unsubscribe@gitlab.example.com>
[...]
Output of checks
sudo gitlab-rake gitlab:incoming_email:check
Checking Incoming Email ...
Incoming Email: ... Checking Reply by email ...
IMAP server credentials are correct? ... yes
Init.d configured correctly? ... no
Try fixing it:
Enable mail_room in the init.d configuration.
For more information see:
doc/administration/reply_by_email.md
Please fix the error above and rerun the checks.
MailRoom running? ... can't check because of previous errors
Checking Reply by email ... Finished
Checking Incoming Email ... Finished
I don't know why I get this error, and there is no mention in the documentation about this mail_room
for Omnibus, only for install from source.
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Debian 9.4 Current User: git Using RVM: no Ruby Version: 2.5.3p105 Gem Version: 2.7.6 Bundler Version:1.16.6 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.18.1 Sidekiq Version:5.2.5 Go Version: unknown
GitLab information Version: 11.9.1 Revision: 86f0b5d Directory: /media/vol2/opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.example.com HTTP Clone URL: https://gitlab.example.com/some-group/some-project.git SSH Clone URL: git@gitlab.example.com:some-group/some-project.git Using LDAP: yes Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 8.7.1 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 8.7.1 ? ... OK (8.7.1) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Checking Reply by email ...
IMAP server credentials are correct? ... yes Init.d configured correctly? ... no Try fixing it: Enable mail_room in the init.d configuration. For more information see: doc/administration/reply_by_email.md Please fix the error above and rerun the checks. MailRoom running? ... can't check because of previous errors
Checking Reply by email ... Finished
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... Server: ldapmain LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results) [...] Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... no Try fixing it: Install the init script For more information see: doc/install/installation.md in section "Install Init Script" Please fix the error above and rerun the checks. Init script up-to-date? ... can't check because of previous errors Projects have namespace: ... 44/2 ... yes 3/3 ... yes [...] 21/91 ... yes 34/92 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.5.3) Git version >= 2.18.0 ? ... yes (2.18.1) Git user has default SSH configuration? ... yes Active users: ... 59
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished