Test Plan for 'Suggest multiple line change within a merge request'
Test Plan
Introduction
Test plan for https://gitlab.com/gitlab-org/gitlab-ce/issues/53310
It should be possible to not just suggest a single line edit but specify a range of lines that can be edited inside a single comment block.
Scope
- Testing to comment on multiple lines of code
- Testing that the commented lines should not be able to go out of scope
- Testing the visual representation of the shown lines
ACC Matrix
Secure | Reliable | |
---|---|---|
MRs | 1 | 3 |
Capabilities
MR
Reliable
- It should accept the new change if accepted and replace every selected line
- It should always show every line selected
- With large selections it should still be reliable to work as intended
Secure
- If the lines are out of scope, it should show only the available lines
Test Plan
Scenario 1
Prep:
- Create a MR
- Create a comment code suggestion on multiple lines
Do:
- Accept this suggestion
Test:
- Accepted and diff shown
Scenario 2
Prep:
- Create a MR
Do:
- Create a comment code suggestion on multiple lines
- Lines should be over the actually available lines
Test:
- It should only show the available lines
Scenario 3
Prep:
- Create a MR
Do:
- Create a comment code suggestion on multiple lines
- Lines should be over 5000
Test:
- It should show all selected lines
Scenario 4
Prep:
- Create a MR
- Create a comment code suggestion on multiple lines
Do:
- Add a new commit changing something in those selected lines
Test:
- It should show the suggestion as outdated
Scenario 5
Prep:
- Create a MR
- Create a comment code suggestion on multiple lines
- Add a new commit changing something in the last selected line
Do:
- Edit the comment to not include this last line
Test:
- It should show the suggestion as not outdated anymore
/cc @oswaldo