Broken master: spec/routing/instance_statistics_routing_spec.rb
As seen, e.g., here: https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/177533155
Knapsack report was generated. Preview:
{
"spec/requests/api/issues_spec.rb": 123.26901054382324,
"spec/lib/gitlab/gpg/commit_spec.rb": 64.99012994766235,
"spec/lib/gitlab/diff/position_tracer_spec.rb": 39.28488278388977,
"spec/requests/git_http_spec.rb": 51.48144459724426,
"spec/features/projects/files/user_creates_directory_spec.rb": 38.209654569625854,
"spec/features/profiles/gpg_keys_spec.rb": 28.142765760421753,
"spec/requests/api/release/links_spec.rb": 21.759511470794678,
"spec/policies/group_policy_spec.rb": 22.963415384292603,
"spec/features/admin/admin_labels_spec.rb": 10.746670961380005,
"spec/features/groups/share_lock_spec.rb": 11.884174585342407,
"spec/models/environment_status_spec.rb": 16.346715450286865,
"spec/models/project_services/kubernetes_service_spec.rb": 16.02661943435669,
"spec/models/ci/runner_spec.rb": 12.752087593078613,
"spec/lib/gitlab/background_migration/create_gpg_key_subkeys_from_gpg_keys_spec.rb": 9.913804531097412,
"spec/serializers/group_child_entity_spec.rb": 11.594225883483887,
"spec/workers/post_receive_spec.rb": 9.4775230884552,
"spec/features/projects/files/project_owner_sees_link_to_create_license_file_in_empty_project_spec.rb": 7.859222650527954,
"spec/features/container_registry_spec.rb": 7.275335073471069,
"spec/requests/api/project_import_spec.rb": 5.772229909896851,
"spec/lib/gitlab/checks/branch_check_spec.rb": 6.0855183601379395,
"spec/features/issues/markdown_toolbar_spec.rb": 6.564686059951782,
"spec/features/search/user_uses_search_filters_spec.rb": 5.870776176452637,
"spec/finders/todos_finder_spec.rb": 6.160789966583252,
"spec/services/ci/update_build_queue_service_spec.rb": 3.4290804862976074,
"spec/lib/gitlab/ci/status/build/retryable_spec.rb": 3.2673559188842773,
"spec/services/files/create_service_spec.rb": 3.1894776821136475,
"spec/controllers/projects/ci/lints_controller_spec.rb": 3.832536220550537,
"spec/services/notes/update_service_spec.rb": 4.102503776550293,
"spec/features/issues/user_edits_issue_spec.rb": 2.9269187450408936,
"spec/models/application_setting_spec.rb": 4.049016237258911,
"spec/controllers/projects/protected_branches_controller_spec.rb": 3.0560250282287598,
"spec/services/search/global_service_spec.rb": 3.305347442626953,
"spec/controllers/profiles/keys_controller_spec.rb": 2.6818530559539795,
"spec/lib/gitlab/plugin_spec.rb": 2.146751880645752,
"spec/helpers/members_helper_spec.rb": 2.5214319229125977,
"spec/lib/gitlab/ci/status/external/common_spec.rb": 2.430682420730591,
"spec/lib/gitlab/data_builder/pipeline_spec.rb": 1.8444273471832275,
"spec/lib/gitlab/ci/trace/stream_spec.rb": 1.8338286876678467,
"spec/features/admin/admin_browses_logs_spec.rb": 1.1384189128875732,
"spec/workers/chat_notification_worker_spec.rb": 1.759303092956543,
"spec/presenters/ci/variable_presenter_spec.rb": 1.5820045471191406,
"spec/lib/banzai/filter/abstract_reference_filter_spec.rb": 1.9307081699371338,
"spec/models/lfs_file_lock_spec.rb": 1.5907118320465088,
"spec/lib/gitlab/graphs/commits_spec.rb": 1.2274565696716309,
"spec/lib/banzai/pipeline/full_pipeline_spec.rb": 1.1366820335388184,
"spec/lib/gitlab/ci/status/pipeline/common_spec.rb": 1.217388391494751,
"spec/routing/environments_spec.rb": 0.6771161556243896,
"spec/views/notify/pipeline_failed_email.html.haml_spec.rb": 1.2194969654083252,
"spec/views/projects/jobs/_generic_commit_status.html.haml_spec.rb": 0.8941318988800049,
"spec/services/wiki_pages/destroy_service_spec.rb": 0.6305599212646484,
"spec/rubocop/cop/migration/update_large_table_spec.rb": 0.4953768253326416,
"spec/helpers/appearances_helper_spec.rb": 0.5732550621032715,
"spec/serializers/issue_entity_spec.rb": 0.6296465396881104,
"spec/workers/mail_scheduler/issue_due_worker_spec.rb": 0.552016019821167,
"spec/migrations/drop_duplicate_protected_tags_spec.rb": 0.7514171600341797,
"spec/lib/gitlab/github_import/parallel_importer_spec.rb": 0.9344766139984131,
"spec/lib/gitlab/auth/user_access_denied_reason_spec.rb": 0.5671601295471191,
"spec/models/system_note_metadata_spec.rb": 0.6762220859527588,
"spec/migrations/remove_empty_extern_uid_auth0_identities_spec.rb": 0.44560790061950684,
"spec/lib/gitlab/background_migration/migrate_system_uploads_to_new_folder_spec.rb": 0.4658043384552002,
"spec/migrations/assure_commits_count_for_merge_request_diff_spec.rb": 0.30463075637817383,
"spec/lib/gitlab/cycle_analytics/updater_spec.rb": 0.7758815288543701,
"spec/lib/gitlab/import_export/saver_spec.rb": 0.29239654541015625,
"spec/serializers/analytics_merge_request_serializer_spec.rb": 0.24997210502624512,
"spec/models/user_callout_spec.rb": 0.40648365020751953,
"spec/lib/gitlab/gitaly_client/conflict_files_stitcher_spec.rb": 0.29166316986083984,
"spec/lib/gitlab/ci/config/entry/reports_spec.rb": 0.2659420967102051,
"spec/lib/gitlab/github_import/client_spec.rb": 0.25865745544433594,
"spec/initializers/direct_upload_support_spec.rb": 0.19548749923706055,
"spec/initializers/attr_encrypted_no_db_connection_spec.rb": 0.20006179809570312,
"spec/lib/gitlab/dependency_linker/gemspec_linker_spec.rb": 0.20407652854919434,
"spec/models/project_services/pivotaltracker_service_spec.rb": 0.25536561012268066,
"spec/services/clusters/build_service_spec.rb": 0.16353225708007812,
"spec/lib/banzai/filter/color_filter_spec.rb": 0.09474968910217285,
"spec/lib/gitlab/hook_data/base_builder_spec.rb": 0.13168644905090332,
"spec/finders/license_template_finder_spec.rb": 0.02369999885559082,
"spec/workers/remote_mirror_notification_worker_spec.rb": 0.0644683837890625,
"spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb": 0.04284977912902832,
"spec/models/badges/group_badge_spec.rb": 0.052191734313964844,
"spec/models/merge_request_diff_file_spec.rb": 0.03217935562133789,
"spec/models/merge_request/metrics_spec.rb": 0.033133506774902344,
"spec/lib/gitlab/request_context_spec.rb": 0.029855966567993164,
"spec/lib/gitlab/query_limiting/middleware_spec.rb": 0.022710800170898438,
"spec/models/project_daily_statistic_spec.rb": 0.01638650894165039,
"spec/lib/gitlab/query_limiting/active_support_subscriber_spec.rb": 0.014659404754638672,
"spec/routing/instance_statistics_routing_spec.rb": 0.056571245193481445,
"spec/initializers/6_validations_spec.rb": 0.01599407196044922,
"spec/services/user_project_access_changed_service_spec.rb": 0.010389089584350586,
"spec/graphql/types/permission_types/project_spec.rb": 0.0060808658599853516,
"spec/lib/gitlab/git/gitmodules_parser_spec.rb": 0.0042192935943603516
}
Knapsack global time execution for tests: 10m 04s
Failures:
1) Instance Statistics routing routes '/-/instance_statistics' to conversational development index
Failure/Error: expect(get('/-/instance_statistics')).to redirect_to('/-/instance_statistics/conversational_development_index')
Expected response to be a <3XX: redirect>, but was a <200: OK>
# ./spec/routing/instance_statistics_routing_spec.rb:9:in `block (2 levels) in <top (required)>'
Finished in 12 minutes 29 seconds (files took 11.61 seconds to load)
1439 examples, 1 failure
Failed examples:
rspec ./spec/routing/instance_statistics_routing_spec.rb:8 # Instance Statistics routing routes '/-/instance_statistics' to conversational development index