Questions about spec/javascripts/fixtures/emojis.rb
The following discussion from !26045 (merged) should be addressed:
-
@winh started a discussion: (+1 comment) My intention in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26011#note_149526860 was actually to remove the logic in https://gitlab.com/gitlab-org/gitlab-ce/blob/41e78a30210c1a02202ff2269554979b6fb18be8/spec/javascripts/fixtures/emojis.rb#L11-12. Sorry for not making this more clear.
😞 Now that I looked at it again, I have some questions though:
- why do we run an RSpec test to copy a file?
- why do we need two identical files
spec/javascripts/fixtures/emojis/emojis.json
andee/spec/javascripts/fixtures/emojis/emojis.json
?
Maybe those should go to the author of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24543 though.
😃 /cc @timzallmann