DeleteDiffFilesWorker reported max allocated memory very high
https://docs.google.com/presentation/d/1BXy1nyE6usmeOjIyMjkpVFrjlZXLh1IRB81FVO3K27U/edit#slide=id.g4d1639bd1e_0_22 says that the max allocated memory for the DeleteDiffFilesWorker during this period was 1.639 GB. That's surprising to me:
- This hasn't changed in the last 9-ish months: https://gitlab.com/gitlab-org/gitlab-ce/commits/master/app/workers/delete_diff_files_worker.rb
- The worker does very little: it loads a single (small-ish) row from the database as an ActiveRecord object, creates a database transaction, and then inside that transaction it updates that row, as well as deleting a bunch of child rows using a single
DELETE
statement. - Looking at that dashboard for the last 7 days (https://dashboards.gitlab.net/d/sQ4GXgpik/memory-usage?orgId=1&from=now-7d&to=now), I get results nowhere near these: 247 MB is the max.
So it seems like it should never use that much memory. If it did use that much memory at some point, I don't understand how it changed. And if it didn't, but the measurements are wrong, then that's also a little concerning.